Pros
Great benefits, including health care, retirement, dental, housing, and family programs. Promotions are almost guranteed for officers up to LTC rank as long as you put the time in. Also has outstanding comaraderie between peers. Every day is different, which can be a challenge, but it also keeps the job interesting. Integrity and courage are valued. Great racial and gender diversity.
Cons
Frequent moves mean you never get really comfortable in a job and they cause stress on families. Frequent deployments also stress families. There's a "we can do it" culture, no matter what the mission, which leads to doing more with fewer resources and less time. Outstanding performance isn't recognized with additional pay or faster promotions, creating little incentive to excel. But the biggest problem is that as officers progress in the Army, many of the best ones tend to get out in favor of civilian jobs, which dilutes the quality of officers at higher levels.